Update pattern overrides handler to retrieve attribute value from new values property#6055
Conversation
… `values` property
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core SVNCore Committers: Use this line as a base for the props when committing in SVN: GitHub Merge commitsIf you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
@talldan, when you are done with all the backports, it would be great to add some basic PHPUnit tests covering how Pattern Overrides work with block bindings. It could be on the |
Backports the changes from WordPress/gutenberg#58596.
The gutenberg PR changes the data structure of the
overridesdata to allow it to be more flexible for future features.Note that it might be best to commit this around the same time as gutenberg package updates land in core so that the block changes and core code changes are synchronized.
Trac ticket: https://core.trac.wordpress.org/ticket/60456
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.